[OH-Dev] [issue665] missions: Make Subversion training mission use Django form validation in a more idiomatic fashion

[Asheesh Laroia]

New submission from Asheesh Laroia <asheesh at asheesh.org>:

Right now, the Subversion training mission uses Django forms in some odd ways.
In particular:

The mysite.missions.svn.views.diff_submit function checks form validation, and
then *separately* validates the patch by a call to
controllers.SvnDiffMission.validate_diff_and_commit_if_ok. Instead, the
validation of the diff should be done during form validation.

mysite.missions.svn.checkout_submit has a similar problem: it tests if the
cleaned_data secret word is the secret word that we asked for; however, this
should be done during form validation.

----------
messages: 2931
nosy: paulproteus
priority: bug
status: unread
title: missions: Make Subversion training mission use Django form validation in a more idiomatic fashion

__________________________________________
Roundup issue tracker <bugs at openhatch.org>
<https://openhatch.org/bugs/issue665>
__________________________________________