[OH-Dev] Reviewing pull requests

[John Morrissey]

On Sun, Jan 12, 2014 at 06:57:43PM -0800, Asheesh Laroia wrote:
> Summary: Merge it, and make a follow-up commit tightening it up.
> 
> Detailed thoughts:
> 
> One of my mental goals for patch review from newcomers is that we
> ship their stuff as soon as feasible. There's nothing like having
> stuff actually land.
[snip]
> Given the goal of low latency, my usual flow chart for this is... well
> it's in my head. I just made a flow chart for the fun of it (it was
> extremely fun). Attached as ASCII art. I made it using asciiflow.com;
> http://www.asciiflow.com/#585181832642635082/1872680033 is the link.
> 
> I'd be quite curious for your thoughts on this flow chart/state machine.

Seems solid. I like your emphasis on turning the patch around quickly, using
IRC or some other low-latency communication channel if it's there. Thanks,
Asheesh.

john
-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__