[OH-Dev] Replace controllers with helpers
Rajesh Pradhan
rajeshpradhan at gmail.com
Sat Mar 30 00:48:25 UTC 2013
Another pull request submitted which the changes Asheesh suggested. Please
review.
Thanks
Rajesh
On Thu, Mar 28, 2013 at 12:26 PM, Asheesh Laroia <asheesh at asheesh.org>wrote:
> On Thu, 28 Mar 2013, Rajesh Pradhan wrote:
>
> That worked. So going forward should I follow these steps to submit pull
>> requests?
>>
>
> Yeah -- generally, it's essential to submit a pull request to the main
> repository, not to your own one. (The idea is you're requesting we "pull"
> code from your fork into the main one.)
>
> And having those pull requests be freshly-rebased is helpful.
>
> -- Asheesh.
>
> ______________________________**_________________
> Devel mailing list
> Devel at lists.openhatch.org
> http://lists.openhatch.org/**mailman/listinfo/devel<http://lists.openhatch.org/mailman/listinfo/devel>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openhatch.org/pipermail/devel/attachments/20130329/d1794934/attachment.html>
More information about the Devel
mailing list