This site is an archive; learn more about 8 years of OpenHatch.

[OH-Dev] GitHub.com Pull Requests and the Bug-Issue Tracker

Asheesh Laroia lists at asheesh.org
Sat Mar 17 20:13:38 UTC 2012


Excerpts from Jacquie Flemming's message of Thu Mar 15 21:41:31 -0400 2012:
> Asheesh,
> 
> For commits made through GitHub.com are we going to add the commit ###s to
> the issue to have the
> issue closed? I know we just started this process but I wasn't sure if we
> were doing this or not at
> sprints. I just updated  https://openhatch.org/bugs/issue665 with my commit
> number.

I think the best thing is:

* Submitter indicates the URL to the pull request on Github.com, and
  marks the ticket need-review

* Person who merges it links to the commit ID of the merge, perhaps as
  a Github.com link, and marks it resolved

> You already started with the guidelines for forking and pushing, so that
> would be a good place
> to add this?? I would say a good practice is that commit comments should
> reference the
> issue number and/or the bug tracker should reference the commit number. And
> I think
> the latter is more necessary.

I agree on these points.

This stuff should get documented in docs/ , IMHO, and contributor documentation
should get moved out of the wiki into docs/.

Would you be willing to submit a patch/pull-request for that? (:

-- Asheesh.


More information about the Devel mailing list