[OH-Dev] [issue484] Crasher bug in the diffsingle training mission

[jesstess]

jesstess <jessica.mckellar at gmail.com> added the comment:

The crash can be exercised by submitting anything that lacks diff headers.

Attached is a patch with a unit test that prints a hint to include those headers instead of crashing. 
This bug also existed for the diffrecursive sub-mission and is fixed by this patch.

I have some commentary on our use of mysite/missions/base/patch.py: we seem to be using code 
copied from http://code.google.com/p/python-patch/. A) this means we aren't seeing upstream 
fixes unless someone is remembering to pull them in regularly, B) I think the line-by-line parsing is 
overkill for the kind of validation we need, and C) it has a bunch of todos and no unit tests, which 
suggests that there are more bugs lurking.

If more bugs crop up, we should consider moving to simpler validation.

----------
status: in-progress -> need-review

__________________________________________
Roundup issue tracker <bugs at openhatch.org>
<https://openhatch.org/bugs/issue484>
__________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-If-a-diffpatch-diff-is-submitted-without-diff-header.patch
Type: application/octet-stream
Size: 3287 bytes
Desc: not available
URL: <http://lists.openhatch.org/pipermail/devel/attachments/20110821/0228ee3c/attachment.obj>