This site is an archive; learn more about 8 years of OpenHatch.

[OH-Dev] Reviewing pull requests

John Morrissey jwm at horde.net
Mon Jan 13 02:32:05 UTC 2014


I'm reviewing a pull request, and the changes have a bunch of places where
the consistency/cruft/style could be better. Nothing fatal, but a general
tightening over the entire patch.

What do you usually do in cases like these? If I have the submitter fix the
patch, I'm going to wind up criticizing (politely) pretty evenly over the
whole thing. Maybe accept it as-is and make a follow-up commit myself
tightening it up?

john
-- 
John Morrissey          _o            /\         ----  __o
jwm at horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__


More information about the Devel mailing list